Add get_daemon#19
Merged
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
Member
Author
|
/lgtm |
Member
Author
|
/kind feature |
InftyAI-Agent
added
the
lgtm
InftyAI-Agent
added
feature
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a get_daemon(daemon_id) lookup API to the Rust-backed server and exposes it through the Python Server wrapper, enabling callers to fetch daemon metadata by ID without listing all daemons.
Changes:
- Add Rust
Server.get_daemon()returning daemon info (orNoneif not connected). - Add Python
Server.get_daemon()returningOptional[DaemonInfo]and updatewait_for_daemon()to use it. - Add unit + integration tests for
get_daemon.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| server/src/lib.rs | Adds a new PyO3-exposed get_daemon method backed by the daemon registry. |
| python/sandd/server.py | Exposes get_daemon in the Python API and uses it to speed up wait_for_daemon. |
| python/tests/test_unit.py | Adds unit tests validating get_daemon returns None when not found. |
| python/tests/test_integration.py | Adds integration tests for get_daemon with real daemon processes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| """ | ||
| return ServerStats(self._server.get_stats()) | ||
|
|
||
| def get_daemon(self, daemon_id: str) -> Optional[DaemonInfo]: |
InftyAI-Agent
removed
the
lgtm
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/lgtm |
InftyAI-Agent
added
the
lgtm
InftyAI-Agent
approved these changes
Jun 16, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?