chore(code-quality): address remaining CodeRabbit feedback from PR #1108

[ashleyshaw]

Overview

This tracks comprehensive code quality improvements identified by CodeRabbit during PR #1108 review. All are improvements (not blockers) to enhance documentation, test coverage, and code robustness.

High-Impact Improvements (5 items)

1. Audit Report Date Placeholders

Files: 4 audit reports
Change: Replace {audit_date} with 2026-07-22

• .github/reports/audits/phase-1-ai-config-audit-2026-07-22.md (line 426)
• .github/reports/audits/phase-1-hooks-audit-2026-07-22.md (line 610)
• .github/reports/audits/phase-1-memory-schema-audit-2026-07-22.md (line 358)
• .github/reports/audits/phase-1-schemas-audit-2026-07-22.md (line 774)

2. UK English Spelling - Audit Prose

Files: 4 audit documents
Change: standardization → standardisation

• .github/reports/audits/phase-1-hooks-audit-2026-07-22.md (line 50)
• .github/reports/audits/phase-1-instructions-audit-2026-07-22.md (line 186)
• .github/reports/audits/phase-1-memory-schema-audit-2026-07-22.md (line 10)
• .github/reports/audits/phase-1-schemas-audit-2026-07-22.md (line 10)

3. UK English Spelling - Framework Document

File: .github/reports/frameworks/agent-standardization-framework-2026-07-22.md
Changes:

• Lines 467-477, 533-539: organization → organisation, customization → customisation
• Line 668-670: Replace {audit_date} with 2026-07-22
• Line 572-589: Update Phase 1C-J status from PENDING to COMPLETED

4. Remove Unfinished Gemini Plugin

File: plugins/lightspeed-playwright-testing/.gemini-plugin/plugin.json
Action: Delete this file
Reason: Unfinished placeholder advertising "planned parity" but not actually wired up to Phase 1

5. Fix Plugin Integrity File Validation

File: hooks/plugin-integrity-checker/index.js (lines 54-61)
Change: Replace fs.existsSync() with fs.statSync().isFile()
Reason: More strict validation (rejects directories as valid files)

Medium-Impact Improvements (4 items)

6. Test Fixture Cleanup

Files: 3 test files
Change: Add afterEach(() => { /* cleanup */ }) blocks

• hooks/agent-security-auditor/tests/agent-security-auditor.test.js
• hooks/agent-spec-validator/tests/agent-spec-validator.test.js
• hooks/multi-provider-consistency-checker/tests/multi-provider-consistency-checker.test.js

7. Add JSDoc Documentation

5 helpers need JSDoc:

• hooks/agent-security-auditor/tests/agent-security-auditor.test.js - tmpDir()
• hooks/agent-security-auditor/index.js - getAllFiles(), lineOf()
• hooks/agent-spec-validator/tests/agent-spec-validator.test.js - tmpAgent()
• hooks/multi-provider-consistency-checker/tests/multi-provider-consistency-checker.test.js - tmpAgent()
• hooks/multi-provider-consistency-checker/index.js - readProviders()

8. Enhance hooks/package.json

Change: Add npm scripts and Jest devDependency
Scripts:

• npm test: Run hook tests
• npm run lint: Lint hook files
• npm run validate: Validate hook JSON files

9. Expand Test Coverage

Test enhancements:

• agent-spec-validator: Test empty/non-array capabilities
• multi-provider-consistency-checker: Test unsupported provider rejection
• plugin-integrity-checker: Test invalid JSON, unsafe refs, non-string refs, missing README

Low-Impact Improvements (3 items)

10. Fix Cookbook Schema Link

File: cookbook/playwright-agent-creation-guide.md (line 55-57)
Change: Update relative path to absolute

• From: schema/multi-provider-agent.schema.json
• To: .github/schema/multi-provider-agent.schema.json

11. Document Plugin Integrity Hook

File: hooks/plugin-integrity-checker/README.md
Add:

• Hook invocation instructions
• Target path inputs
• Validation result fields
• Exit-code behavior
• Error handling

12. Isolate Plugin Integrity Unit Tests

File: hooks/plugin-integrity-checker/tests/plugin-integrity-checker.test.js
Change: Move "validates the real lightspeed-playwright-testing plugin" test to integration suite
Reason: Keep unit tests hermetic (no external file dependencies)

---

Checklist

• Apply all 12 improvements
• Run linting and formatting
• Verify all tests pass
• Commit to feat/agent-standards-playwright-testing
• Create PR for code review
• Merge to develop

Related Issues

• PR feat(agents): Playwright Testing Agent multi-provider rewrite + Phase 1 standardization infra #1108 (CodeRabbit review source)
• test(hooks): add regression test coverage for validation edge cases #1120 (Test coverage gaps)

Labels

test, code-quality, documentation, area:ci

[linear-code]

LS-1691

[github-actions]

⚠️ This issue does not follow a required issue template.

Missing required section(s): Definition of Ready (DoR), Definition of Done (DoD)

The issue will remain open and flagged until the body is corrected.
Please update the issue with one of the official templates:

• https://github.com/lightspeedwp/.github/issues/new/choose

If this was opened by automation, update the automation to preserve the template sections before creating the issue.

[github-actions]

⏱️ Aging and SLA annotation

• Age: 0 day(s)
• SLA state: Within SLA
• Thresholds: warn at 7 days, breach at 14 days
• Last updated: 2026-07-22T16:26:47.856Z

Maintained by project-meta-sync workflow.