fix: resolve vLLM training gibberish outputs for Gemma 3/4 scanned layers#4519
Open
mesakhcienet wants to merge 1 commit into
Open
fix: resolve vLLM training gibberish outputs for Gemma 3/4 scanned layers#4519mesakhcienet wants to merge 1 commit into
mesakhcienet wants to merge 1 commit into
Conversation
mesakhcienet
marked this pull request as ready for review
July 17, 2026 11:23
mesakhcienet
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025,
vipannalla and
xibinliu
as code owners
July 17, 2026 11:23
SurbhiJainUSC
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes multiple issues causing gibberish outputs and initialization crashes when using scan_layers=True with Gemma 3 and 4 in vLLM workflows.
Context and Details:
vLLM rollout engine.
kv_cachesargument in_apply_gemma3_scanned_blocks, which caused loss of attention context.MaxTextVllmRolloutignoredrollout_vllm_additional_config, falling back to base configs that conflicted with HuggingFace config head dimensions.scan_lengthcalculation for scalar RNG states caused it to drop all decoder parameters, resulting in random noise generation.kv_cachesand attention_metadata in decoder blocks.scan_length, and correctly broadcast scalar values during unstacking.Tests
inference vllm_decode
Run script : here
Run output : log
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.