Skip to content

fix: version parsing failure on nightly tags #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajrangCoder merged 1 commit into from
Jun 16, 2026
+13 −2
Merged

fix: version parsing failure on nightly tags #2249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,11 +338,22 @@ async function onDeviceReady() {
(response) => {
const release = response.data;
// assuming version is in format v1.2.3
const versionFormat = /^v?(\d+(?:\.\d+)*)/;
const latestVersion = release.tag_name
.replace("v", "")
.match(versionFormat)?.[1]
.split(".")
.map(Number);
const currentVersion = BuildInfo.version.split(".").map(Number);
const currentVersion = BuildInfo.version
.match(versionFormat)?.[1]
.split(".")
.map(Number);
if (!(latestVersion && currentVersion)) {
window.log(
"error",
"Failed to parse version while checking for updates.",
);
return;
}
Comment thread
AuDevTist1C marked this conversation as resolved.

let hasUpdate = false;
for (let i = 0; i < latestVersion.length; i++) {
Expand Down