Skip to content

Revert "Don't record private IP literals as outbound hostnames (Zen alert flood)"#309

Open
bitterpanda63 wants to merge 1 commit into
mainfrom
revert-308-fix/dns-collector-skip-private-ip-literals
Open

Revert "Don't record private IP literals as outbound hostnames (Zen alert flood)"#309
bitterpanda63 wants to merge 1 commit into
mainfrom
revert-308-fix/dns-collector-skip-private-ip-literals

Conversation

@bitterpanda63

@bitterpanda63 bitterpanda63 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Reverts #308

Summary by Aikido

Security Issues: 0 Quality Issues: 0 Resolved Issues: 0

⚡ Enhancements

  • Reinstated recording of private IP literals as outbound hostnames
  • Removed IsPrivateIP import and conditional filtering with explanatory comments

More info

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants