Fix blank error screen for unrecognized deck aspect ratios

[NKoech123]

Summary

Fixes a crash that produced a blank error screen when opening or refining a deck with an unrecognized aspect ratio.

Problem

When a deck had an aspect ratio value that wasn't one of the recognized presets, getAspectRatioDims would return undefined, which caused the app to crash with a blank error screen instead of rendering the deck.

Solution

Made getAspectRatioDims resilient to unknown or invalid aspect ratio values by falling back to the default (16:9) instead of returning undefined. Also tightened the patch-deck action's validation so aspect ratio values are constrained to the known set at the API boundary.

Key Changes

• getAspectRatioDims now falls back to ASPECT_RATIOS["16:9"] for any falsy or unrecognized aspect ratio input, rather than returning undefined.
• patch-deck.ts now validates aspectRatio against ASPECT_RATIO_VALUES using a Zod enum instead of a plain string, preventing invalid values from being persisted.
• Updated tests in aspect-ratios.test.ts to reflect the new fallback behavior for bogus and empty string values.
• Added a changelog entry documenting the fix.

---

  

---

To clone this PR locally use the Github CLI with command gh pr checkout 2360

You can tag me at @BuilderIO for anything you want me to fix or change

[github-actions]

Here's a visual recap of what changed:

Open the full interactive recap

[builder-io-integration]

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review Summary

The updated PR addresses the previous review finding correctly. getAspectRatioDims now checks that a ratio is an own property of ASPECT_RATIOS, so malformed legacy values such as toString, constructor, and hasOwnProperty safely fall back to 16:9 rather than returning inherited functions. The added regression tests cover those keys along with unknown and empty values, while the shared Zod enum continues to constrain new patch-deck writes.

Two independent incremental reviews found no new reportable bugs; one noted only a low-severity cleanup opportunity in an unmodified PDF export caller (an outdated comment/dead nullish fallback), which is not actionable in this PR and is below the review threshold. One reviewer also reported that the full focused suite passed: 68 files and 353 tests, with formatting passing.

Risk remains standard because this changes shared rendering/export behavior and an action validation boundary. The previously reported inherited-key issue has been fixed and its review thread was resolved.

🧪 Browser testing: Will run after this review (PR touches UI code)