Trigger Tableau TDVT in connectors on snapshot publish and release (CON-264)#2875
Merged
Conversation
|
Repository collaborators can run the JMH benchmark suite against this PR by commenting: Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%): Only one benchmark run per PR is active at a time — issuing a new |
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
Contributor
|
Thank you for the PR! |
chernser
reviewed
Jun 11, 2026
ShimonSte
force-pushed
the
tdvt-dispatch
branch
2 times, most recently
from
June 24, 2026 12:42
d916ce5 to
6eeba6e
Compare
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chernser
reviewed
Jul 24, 2026
chernser
approved these changes
Jul 24, 2026
Tableau users install the latest ClickHouse JDBC driver manually, so a snapshot or release regression reaches them with no connector release in between. After a snapshot/release publishes, fire a repository_dispatch to ClickHouse/connectors so its Tableau TDVT suite runs against the new driver. Tracking: CON-264. - nightly.yml: dispatch event_type=jdbc-snapshot; version derived from the pom <revision> property (env.CHC_VERSION is commented out). - release.yml: dispatch event_type=jdbc-release with the release version input. - Both are continue-on-error so a dispatch failure never fails the publish, and require secrets.CONNECTORS_DISPATCH_TOKEN (Contents:read/write on connectors).
Run TDVT in a separate job against clickhouse-tableau-tdvt, wait for the run to finish, and surface its outcome in the publishing workflow. Add mirror_tdvt.py for dispatch and run matching, and capture the nightly JDBC version before Maven flatten removes <revision>.
Match the dispatched TDVT run STRICTLY on the unique correlation id embedded in the run-name, dropping the version/timing heuristics that could pick an unrelated run sharing the same JDBC version (Bugbot). Depends on the tdvt-repo run-name change that appends [corr:<id>] to the TDVT run title.
TriageCategory: Summary What this impacts
Concerns
Required reviewer action
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d329310. Configure here.
The release workflow_dispatch has no 'version' input, so github.event.inputs.version was empty and TDVT was dispatched with no version (Bugbot). The release publishes $(cat VERSION) (Update Configuration writes it into the pom <revision> before deploy), so the tdvt job reads the same VERSION file to test the artifact that was actually published.
|
Current version of PR was reviewed by /review-bugbot on Jul 27, 12:02 GMT+3. It flagged 1 finding. Show 1 finding1. Correlation ID substring false match
Bugbot on commit |
Substring correlation matching could associate #run-2 with #run-20 when both runs were visible.
|
Current version of PR was reviewed by /review-bugbot on Jul 27, 12:37 GMT+3. It flagged 0 findings. Bugbot on commit |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tableau users install the latest ClickHouse JDBC driver manually, so a snapshot or release regression reaches them with no connector release in between. After a publish, fire a
repository_dispatchtoClickHouse/connectorsso its Tableau TDVT suite runs against the new driver. Tracking: CON-264.nightly.yml: dispatchevent_type=jdbc-snapshot; version derived from the pom<revision>property (env.CHC_VERSIONis commented out).release.yml: dispatchevent_type=jdbc-releasewith the releaseversioninput.continue-on-errorso a dispatch failure never fails the publish, and requiresecrets.CONNECTORS_DISPATCH_TOKEN(Contents: read/write on connectors only).