tests: fix flaky bwatch 1-block reorg test#9258
Merged
sangbida merged 1 commit intoJun 25, 2026
Merged
Conversation
The test mined a block and then reorged it, but it did not wait until bwatch had actually seen that block first. Sometimes bwatch was still one block behind. In that case, the replacement block looked like a normal new block, not a reorg, so the test waited forever for "Reorg detected". Wait until bwatch has stored the block before reorging it.
sangbida
force-pushed
the
fix/bwatch-reorg-flaky-test
branch
from
711b49d to
fd41939
Compare
Lagrang3
approved these changes
Jun 25, 2026
Lagrang3
left a comment
Lagrang3
left a comment
Collaborator
There was a problem hiding this comment.
Ack.
It Looks robust now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9253
The test mined a block and then reorged it, but it did not wait until bwatch had actually seen that block first.
Sometimes bwatch was still one block behind. In that case, the replacement block looked like a normal new block, not a reorg, so the test waited forever for "Reorg detected".
Wait until bwatch has stored the block before reorging it.
Changelog-None