Skip to content

Validate candidate pruning probability matrices#2778

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix-candidate-pruning-probability-range
Jun 23, 2026
Merged

Validate candidate pruning probability matrices#2778
FlorianPfaff merged 2 commits into
mainfrom
fix-candidate-pruning-probability-range

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Reject finite candidate-pruning probability entries outside [0, 1] instead of letting invalid probabilities select candidates.
  • Keep non-finite probabilities as non-selecting entries, matching the existing threshold mask behavior.
  • Add regression coverage for out-of-range and non-finite probability entries.

Testing

  • Added focused regression tests in tests/test_candidate_pruning.py.

Bug

Before this change, probability_matrix=[[1.2, 0.5]] with probability_threshold=0.5 would treat 1.2 as a valid high probability and retain that candidate. Probability-threshold pruning should only accept finite probabilities in [0, 1].

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 42.07s
✅ JSON prettier 7 0 0 0 0.97s
✅ JSON v8r 7 0 0 3.15s
✅ MARKDOWN markdownlint 68 0 0 0 1.51s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.66s
✅ PYTHON black 890 7 0 0 37.19s
✅ PYTHON isort 890 8 0 0 3.46s
✅ REPOSITORY checkov yes no no 38.3s
✅ REPOSITORY gitleaks yes no no 6.51s
✅ REPOSITORY git_diff yes no no 0.07s
✅ REPOSITORY secretlint yes no no 17.76s
✅ REPOSITORY syft yes no no 3.0s
✅ REPOSITORY trivy-sbom yes no no 4.3s
✅ REPOSITORY trufflehog yes no no 19.99s
✅ YAML prettier 11 0 0 0 0.56s
✅ YAML v8r 11 0 0 8.96s
✅ YAML yamllint 11 0 0 0.44s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 37ba9af into main Jun 23, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant