Skip to content

Validate similarity min_score inputs#2779

Merged
FlorianPfaff merged 3 commits into
mainfrom
fix-similarity-min-score-validation
Jun 23, 2026
Merged

Validate similarity min_score inputs#2779
FlorianPfaff merged 3 commits into
mainfrom
fix-similarity-min-score-validation

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Normalize min_score in solve_multisession_assignment_from_similarity through a scalar finite-value validator.
  • Reject booleans, non-finite values, and non-scalar arrays with a controlled ValueError instead of accepting or leaking low-level conversion errors.
  • Add focused regression tests for accepted scalar arrays and invalid min_score inputs.

Testing

  • Added tests/test_multisession_assignment_similarity_min_score.py.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 64.84s
✅ JSON prettier 7 0 0 0 0.96s
✅ JSON v8r 7 0 0 5.14s
✅ MARKDOWN markdownlint 68 0 0 0 1.91s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.86s
✅ PYTHON black 891 7 0 0 56.55s
✅ PYTHON isort 891 8 0 0 3.61s
✅ REPOSITORY checkov yes no no 46.47s
✅ REPOSITORY gitleaks yes no no 9.29s
✅ REPOSITORY git_diff yes no no 0.1s
✅ REPOSITORY secretlint yes no no 27.07s
✅ REPOSITORY syft yes no no 2.02s
✅ REPOSITORY trivy-sbom yes no no 10.21s
✅ REPOSITORY trufflehog yes no no 22.01s
✅ YAML prettier 11 0 0 0 0.79s
✅ YAML v8r 11 0 0 11.39s
✅ YAML yamllint 11 0 0 0.41s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 635cda9 into main Jun 23, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant