Skip to content

Validate particle resampling sample count#2787

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix-particle-resampling-num-samples-clean
Jun 23, 2026
Merged

Validate particle resampling sample count#2787
FlorianPfaff merged 2 commits into
mainfrom
fix-particle-resampling-num-samples-clean

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Validate particle_resampling scenario num_samples as a positive integer before sampling.
  • Reject zero, negative, fractional, and boolean sample counts instead of producing empty/NaN estimates or relying on backend-level errors.
  • Add regression coverage for invalid num_samples TOML values.

Bug

Before this change, num_samples = 0 reached sampled_mean = ... / float(num_samples), yielding a degenerate non-finite scenario estimate instead of a clear configuration error. Fractional values were also silently truncated via int(...).

Testing

  • Added focused regression coverage in tests/test_scenario_registry_and_reproducibility.py.
  • Not run locally; this environment cannot clone GitHub or install the repository dependencies, so CI should run the tests on the PR.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 54.96s
✅ JSON prettier 7 0 0 0 0.84s
✅ JSON v8r 7 0 0 4.86s
✅ MARKDOWN markdownlint 68 0 0 0 1.51s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.59s
✅ PYTHON black 890 10 0 0 49.32s
✅ PYTHON isort 890 11 0 0 2.96s
✅ REPOSITORY checkov yes no no 43.35s
✅ REPOSITORY gitleaks yes no no 10.01s
✅ REPOSITORY git_diff yes no no 0.13s
✅ REPOSITORY secretlint yes no no 26.92s
✅ REPOSITORY syft yes no no 4.02s
✅ REPOSITORY trivy-sbom yes no no 7.15s
✅ REPOSITORY trufflehog yes no no 21.88s
✅ YAML prettier 11 0 0 0 0.69s
✅ YAML v8r 11 0 0 9.81s
✅ YAML yamllint 11 0 0 0.8s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 6358da5 into main Jun 23, 2026
26 checks passed
@FlorianPfaff FlorianPfaff deleted the fix-particle-resampling-num-samples-clean branch June 23, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant