Remove webkit dep#479
Merged
Merged
Conversation
The New Dataset/Attribute help popups used an SWT Browser (a native web engine), which pulled in a hard webkit package dependency. That made the generated RPM uninstallable on RHEL 9 (it Requires webkit2gtk4.1, which RHEL 9 does not ship) and the DEB fragile across Ubuntu releases. The Browser was only used to render a few static help messages. - Render the help with a read-only, word-wrapped StyledText widget and inline the help text. The .html help resources were never packaged into the jar, so the Browser popups already failed to load in shipped builds. - Drop the webkit entry from the RPM and DEB jpackage --linux-package-deps. - Delete the now-unused NewAttrHelp.html / NewDatasetHelp.html.
jhendersonHDF
approved these changes
Jul 20, 2026
jhendersonHDF
left a comment
jhendersonHDF
left a comment
Collaborator
There was a problem hiding this comment.
Seems reasonable; a bit unfortunate that we (presumably) lose HTML support, but for such a small bit of information that wasn't previously being displayed anyway that seems like a minor detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The New Dataset/Attribute help popups used an SWT Browser (a native web engine), which pulled in a hard webkit package dependency. That made the generated RPM uninstallable on RHEL 9 (it Requires webkit2gtk4.1, which RHEL 9 does not ship) and the DEB fragile across Ubuntu releases. The Browser was only used to render a few static help messages.