Skip to content

Feat: DisplayName for JavaPackageType#6377

Open
KSSJW wants to merge 1 commit into
HMCL-dev:mainfrom
KSSJW-Contribution:java-package-type-display-name
Open

Feat: DisplayName for JavaPackageType#6377
KSSJW wants to merge 1 commit into
HMCL-dev:mainfrom
KSSJW-Contribution:java-package-type-display-name

Conversation

@KSSJW

@KSSJW KSSJW commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

JavaPackageType增加了显示名称

  • 使用 显示名称 而不是直接枚举。
  • 类似 Azul Zulu 网站中加入 空格 视觉上可能会更好。(如 JDKFX -> JDK FX

样式来源

A1

实况

更改前 更改后
B1 B2

@KSSJW

KSSJW commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a display name property to the JavaPackageType enum and configures the packageTypeBox combo box in JavaDownloadDialog to use this display name via a string converter. This ensures that the Java package types are rendered with user-friendly names in the UI. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@KSSJW KSSJW left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@KSSJW KSSJW marked this pull request as ready for review July 11, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant