Harden edgezero #269 runtime config-store load (HTTP layer)#783
Open
prk-Jr wants to merge 4 commits into
Open
Conversation
14a91cc to
bd85e3e
Compare
76031c1 to
84f35fe
Compare
79911d6 to
bdb9284
Compare
Reads (blob key + each chunk) map to ConfigStoreUnavailable (503); envelope/ chunk verification and settings validation stay Configuration (500). Covers the blob/chunk load model on the updated ts-cli-audit base.
84f35fe to
854edef
Compare
ChristianPavilonis
left a comment
Collaborator
There was a problem hiding this comment.
Automated review:
Review Summary
Reviewed PR #783 against feature/ts-cli-audit, focusing on the runtime config-store load path, error-stack context/status behavior, Fastly/EdgeZero HTTP error rendering, public error-body leakage, and the added regression tests. I did not find any blocking correctness, security, data-loss, authorization, or severe compatibility issues in the changed code.
Findings
No blocking findings.
CI / Existing Reviews
- GitHub checks currently show
prepare integration artifactsfailing, with downstream jobs skipped. The failure is dependency-lock parity drift incrates/trusted-server-integration-tests/Cargo.lock(for exampleanyhow,cssparser,html5ever,scraper,uuid, and related transitive dependencies). This should be resolved or confirmed as inherited from the stacked/base branch before merge. - Existing PR reviews: none returned by the GitHub API. Existing inline review comments: none.
- Local focused check passed:
cargo test -p trusted-server-core settings_data --target wasm32-wasip1. A local Fastly adapter-focused test could not complete because this environment hasviceroy 0.16.4while the repo pins0.17.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stackpop/edgezero#269. Stacked onfeature/ts-cli-next(which carries the As a buyer, I want the first bid request to include IAB cohorts, signals, and synthetic ID #269 repin,Bodyfixes, the Fastly adapter migration, and config-store-backedSettingsload). Draft — base is unmerged; retarget tomainoncets-cli-nextlands.TrustedServerError::ConfigStoreUnavailable→ 503, while a reconstruct/verify failure (settings_from_config_entries: hash mismatch / unparseable) stays 500. One new error variant; no platform-layer change.run \ts config push``) goes to server logs (error chain); the public 503 body stays generic by design.Base note: diff is against
feature/ts-cli-next, so it shows only this branch's work. Againstmainit would include all ofts-cli-next.Changes
crates/trusted-server-core/src/error.rsConfigStoreUnavailable { store_name, message }variant → 503 (+ exhaustiveness guard, unit test)crates/trusted-server-core/src/settings_data.rsread_config_entryread failures →ConfigStoreUnavailable; tests (unseeded→503, malformed-hash→500, missing-listed-key→503, hint-in-chain)crates/trusted-server-adapter-fastly/src/error.rsConfigStoreUnavailablerenders 503 to client viato_error_responsecrates/integration-tests/Cargo.lockCloses
n/a — issue linking skipped by request.
Test plan
cargo test --workspace(core 1376 / adapter 39, 0 fail)cargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkcargo build -p trusted-server-adapter-fastly --release --target wasm32-wasip1Checklist
log, colocated tests)unwrap()in production code