Show field names in bulk upload error file (#2534)#2780
Open
Tarekchehahde wants to merge 1 commit into
Open
Conversation
Map validation errors to spreadsheet column labels: non_field_errors become General Error, location errors attach to Latitude/Longitude, and serializer validate() now raises field-keyed errors for branch names and coordinates. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
non_field_errorsto a General Error column in the exported error xlsxlocationvalidation failures to Latitude and Longitude error columnsLocalUnitBulkUploadDetailSerializerfor missing branch names and coordinates (instead of plain-string errors with no column)local_units/test_bulk_upload_errors.pycovering ErrorWriter column mappingCloses #2534
Context
ErrorWriteralready added per-field_errorcolumns, but many serializer failures used stringValidationErrormessages or internal keys (location,non_field_errors) that did not line up with spreadsheet headers.Test plan
docker-compose run --rm test pytest local_units/test_bulk_upload_errors.py(requires project docker env + GDAL)Latitude_error/Longitude_errorcolumns in error fileMade with Cursor