update listDaemons to return a structure#17
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the Python-facing Server.list_daemons() API to return structured daemon metadata (id, version, labels, busy state) instead of a list of daemon ID strings, and updates the Python wrapper/tests/examples accordingly.
Changes:
- Update the Rust
_coreServer.list_daemons()binding to returnPyDaemonInfoobjects. - Add a Python
DaemonInfomodel and adaptpython/sandd/server.pyto returnList[DaemonInfo]. - Update integration/e2e tests and examples to use
daemon.idrather than treating results as strings.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/lib.rs | Changes Rust list_daemons binding to return structured PyDaemonInfo and registers the new pyclass. |
| python/sandd/server.py | Wraps Rust PyDaemonInfo results into Python DaemonInfo; updates broadcast/wait logic to use .id. |
| python/sandd/models.py | Introduces DaemonInfo Python model. |
| python/sandd/init.py | Exposes DaemonInfo in the public Python package exports. |
| python/tests/test_integration.py | Updates assertions to handle structured daemon results. |
| python/tests/test_e2e.py | Updates e2e assertions to handle structured daemon results. |
| examples/interactive_session.py | Updates example to use daemon.id/daemon.version. |
| examples/install_htop.py | Updates example to use daemon.id/daemon.version. |
| examples/exec_commands.py | Updates example to iterate daemons as objects and use daemon.id. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/lgtm |
InftyAI-Agent
added
lgtm
InftyAI-Agent
approved these changes
Jun 14, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?