Unify vkb::PipelineState and vkb::rendering::HPPPipelineState into vkb::rendering::PipelineState<bindingType>#1549
Merged
marty-johnson59 merged 1 commit intoJul 13, 2026
Conversation
054e98a to
4f9dcb5
Compare
…b::rendering::PipelineState<bindingType>
4f9dcb5 to
578e76f
Compare
gpx1000
approved these changes
Jun 29, 2026
gpx1000
left a comment
Collaborator
There was a problem hiding this comment.
Works well here Linux NVIDIA
tomek-brcm
approved these changes
Jul 1, 2026
Collaborator
Can you elaborate on why they are failing? Do they crash? |
Contributor
Author
|
Collaborator
|
Thanks. So it's not the sample code itself that's wrong but rather validation errors. If I run into those with the batch mode, I disable validation. The one for the local read sample is a false positive, we'll have to wait for LunarG to fix/updates the validation layers. |
SaschaWillems
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Next unified class on C- and C++-bindings.
Build tested on Win11 with VS2026. Run tested on Win10 with NVidia GPU.
Note: did not run extensions samples
dynamic_rendering_local_read,fragment_shading_rate_dynamic, andray_tracing_invocation_reorder, as they are failing with both main and this branch.General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: