Skip to content

Unify vkb::PipelineState and vkb::rendering::HPPPipelineState into vkb::rendering::PipelineState<bindingType>#1549

Merged
marty-johnson59 merged 1 commit into
KhronosGroup:mainfrom
asuessenbach:unify_PipelineState
Jul 13, 2026
Merged

Unify vkb::PipelineState and vkb::rendering::HPPPipelineState into vkb::rendering::PipelineState<bindingType>#1549
marty-johnson59 merged 1 commit into
KhronosGroup:mainfrom
asuessenbach:unify_PipelineState

Conversation

@asuessenbach

Copy link
Copy Markdown
Contributor

Description

Next unified class on C- and C++-bindings.

Build tested on Win11 with VS2026. Run tested on Win10 with NVidia GPU.

Note: did not run extensions samples dynamic_rendering_local_read, fragment_shading_rate_dynamic, and ray_tracing_invocation_reorder, as they are failing with both main and this branch.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@asuessenbach asuessenbach force-pushed the unify_PipelineState branch 3 times, most recently from 054e98a to 4f9dcb5 Compare June 22, 2026 16:19
@asuessenbach asuessenbach requested a review from a team June 29, 2026 15:08
@asuessenbach asuessenbach force-pushed the unify_PipelineState branch from 4f9dcb5 to 578e76f Compare June 29, 2026 15:47

@gpx1000 gpx1000 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well here Linux NVIDIA

@SaschaWillems

Copy link
Copy Markdown
Collaborator

Note: did not run extensions samples dynamic_rendering_local_read, fragment_shading_rate_dynamic, and ray_tracing_invocation_reorder, as they are failing with both main and this branch.

Can you elaborate on why they are failing? Do they crash?

@asuessenbach

Copy link
Copy Markdown
Contributor Author

Can you elaborate on why they are failing?

  • dynamic_rendering_local_read: some errors, starting with
[error] -2002814013 - VUID-vkCmdBeginRendering-pRenderingInfo-09592: vkCmdBeginRenderingKHR(): pRenderingInfo->pColorAttachments[0] (VkImage 0x50000000005, layer 0, mip 0) is expected to have layout VK_IMAGE_LAYOUT_RENDERING_LOCAL_READ but previous known layout is VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL.
The Vulkan spec states: For each element of pRenderingInfo->pColorAttachments, if imageView is not VK_NULL_HANDLE, when that image view is accessed it must be in the layout specified by the imageLayout member of that same element of pRenderingInfo->pColorAttachments (https://docs.vulkan.org/spec/latest/chapters/renderpass.html#VUID-vkCmdBeginRendering-pRenderingInfo-09592)
  • fragment_shading_rate_dynamic: some errors, starting with
[error] 485274932 - UNASSIGNED-non-acquired-swapchain-image-used: vkQueueSubmit(): pSubmits[0] performs a layout transition on presentable VkImage 0x50000000005, but the image has not been acquired from VkSwapchainKHR 0x40000000004 (either never or since the last present operation).
The Vulkan spec states: Use of a presentable image must occur only after the image is returned by vkAcquireNextImageKHR, and before it is released by vkQueuePresentKHR. This includes transitioning the image layout and rendering commands (https://docs.vulkan.org/refpages/latest/refpages/source/VkSwapchainKHR.html#_description)
  • ray_tracing_invocation_reorder: no error any more, neither with main, nor with this branch.

@SaschaWillems

Copy link
Copy Markdown
Collaborator

Thanks. So it's not the sample code itself that's wrong but rather validation errors. If I run into those with the batch mode, I disable validation. The one for the local read sample is a false positive, we'll have to wait for LunarG to fix/updates the validation layers.

@marty-johnson59 marty-johnson59 merged commit 77fb9aa into KhronosGroup:main Jul 13, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants