Skip to content

Move call to ApiVulkanSample::submit_frame to after submitting both graphics command buffers#1553

Merged
marty-johnson59 merged 1 commit into
KhronosGroup:mainfrom
asuessenbach:fragment_shading_rate_dynamic
Jul 13, 2026
Merged

Move call to ApiVulkanSample::submit_frame to after submitting both graphics command buffers#1553
marty-johnson59 merged 1 commit into
KhronosGroup:mainfrom
asuessenbach:fragment_shading_rate_dynamic

Conversation

@asuessenbach

Copy link
Copy Markdown
Contributor

Description

Fixes validation layer error

vkQueueSubmit(): pSubmits[0] performs a layout transition on presentable VkImage 0x50000000005, but the image has not been acquired from VkSwapchainKHR 0x40000000004 (either never or since the last present operation).
The Vulkan spec states: Use of a presentable image must occur only after the image is returned by vkAcquireNextImageKHR, and before it is released by vkQueuePresentKHR. This includes transitioning the image layout and rendering commands (https://docs.vulkan.org/refpages/latest/refpages/source/VkSwapchainKHR.html#_description)

Build tested on Win11 with VS2026. Run tested on Win11 with NVidia GPU.

Note: the left upper part of the window shows a smaller view of the graphics window, its size depends on the "Subpass size reduction" control, hiding parts or all of the GUI. Is that intended?

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@asuessenbach asuessenbach requested a review from a team July 9, 2026 14:30
@tomek-brcm

Copy link
Copy Markdown

Not supported for Broadcom

@marty-johnson59 marty-johnson59 merged commit e5d1436 into KhronosGroup:main Jul 13, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants