Add AppImage distribution#486
Conversation
is being supported on that version)
|
@benjamimgois tested it and sait it worked like a charm
|
|
Thanks for the pull request. I'm not familiar with AppImage packaging, so I've been investigating the space a bit. Long story short: I don't think this PkgForge-based packaging approach is a good fit for my development process. I've manually built, tested and published a small set of artifacts for each Protontricks release (mostly just a signed git tag, and a Python wheel and sdist). The latter are published to PyPI using 2FA. The lack of automation for version releases is on purpose and I'd like to keep it that way. The PkgForge tooling relies on downloading build scripts from the main branch of several GitHub repos and running them in turn. This makes reproducing the same build environment more difficult compared to something like appimage-builder does have its own set of downsides:
ProtonUp-Qt seems to be using it with no problems. I tested the downstream AppImage and there were a few missing dependencies: I submitted a pull request at pkgforge-dev/Protontricks-AppImage#11. |
I could just remove the workflow?
you could pin the commit of the scripts which shoukd work fine? as for nixos, most users of that gonna be using the native pkg anyways
those were already known, we didnt bother to update that since we thoughr youd be down to merge this Edit: I just realized we're not talking about the same dependencies so yea i could add those to this pr as well With all of that being said if you still think it's not a good idea to use sharun i umderstand |
Repos? All scripts are downloaded from the main repo. And you can easily pin the scripts to a specific commit if needed.
We are 100% the same in here.
The AppImage was a long pending request from an Alpine linux user (musl) which works. pkgforge-dev/Anylinux-AppImages#238 appimagebuilder doesn't produce appimages that work in musl systems.
|

Added protontricks logo from flatpak pkgs (named with reverse dns just like the flatpak id)
Added StartupWMClass to the .desktop file (sharun complains otherwise)
Added appimage ci (builds it off of the pkgbuild then converts it to appimage)
Updated actions versions