Skip to content

GEOPY-2544: Add mechanics to re-start inversion if results are present in the SimPEGGroups#161

Merged
domfournier merged 8 commits into
developfrom
GEOPY-2544
Jul 7, 2026
Merged

GEOPY-2544: Add mechanics to re-start inversion if results are present in the SimPEGGroups#161
domfournier merged 8 commits into
developfrom
GEOPY-2544

Conversation

@domfournier

@domfournier domfournier commented Jun 30, 2026

Copy link
Copy Markdown

GEOPY-2544 - Add mechanics to re-start inversion if results are present in the SimPEGGroups

Copilot AI review requested due to automatic review settings June 30, 2026 19:56
@github-actions github-actions Bot changed the title GEOPY-2544 GEOPY-2544: Add mechanics to re-start inversion if results are present in the SimPEGGroups Jun 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to enable “resume/re-start” inversion workflows by making optimization / directive logic less dependent on iter == 0 and by preventing first-iteration outputs from being rewritten when prior results already exist (e.g., in SimPEGGroups / GeoH5 outputs).

Changes:

  • Adjust optimization initialization and stopping-criteria baselining to better support resumed runs (and tweak iteration print formatting precision).
  • Update GeoH5 saving directives to avoid writing iteration-0 outputs on non-zero opt.iter, and refine how data entity types are handled when writing.
  • Improve directive behavior for scaling misfit multipliers and ensure Dask inverse problems recompute residuals when missing.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
simpeg/optimization.py Changes iteration printing precision and alters optimizer iteration / baseline initialization to support restart/resume flows.
simpeg/directives/_sim_directives.py Refactors cross-gradient scaling to accept an explicit model argument and calls it from endIter.
simpeg/directives/_save_geoh5.py Skips writing iteration 0 on resumed runs and adjusts entity type handling when writing GeoH5 data/logs.
simpeg/directives/_directives.py Updates ScaleMisfitMultipliers to support restarts and adds a cooling factor concept plus higher-precision logging.
simpeg/dask/inverse_problem.py Ensures residuals are recomputed when absent even if the model hasn’t changed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread simpeg/optimization.py
Comment thread simpeg/optimization.py
Comment thread simpeg/directives/_save_geoh5.py
Comment thread simpeg/directives/_directives.py
Comment thread simpeg/directives/_directives.py
Comment thread simpeg/optimization.py
Comment thread simpeg/directives/_save_geoh5.py Outdated
@domfournier
domfournier merged commit 8546864 into develop Jul 7, 2026
13 checks passed
@domfournier
domfournier deleted the GEOPY-2544 branch July 7, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants