refactor(web): aggregate ConversationPane and Sidebar props into view-models#986
Open
wbxl2000 wants to merge 3 commits into
Open
refactor(web): aggregate ConversationPane and Sidebar props into view-models#986wbxl2000 wants to merge 3 commits into
wbxl2000 wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: e9ba559 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A — internal refactor, no user-facing behavior change.
Problem
App.vuedrilled dozens ofclientfields intoConversationPane.vue(~50 props) andSidebar.vue(~10 props) one by one. The wide prop surfaces made the components hard to maintain: adding or renaming a field meant touching the parent, the child's prop list, and every usage site.What changed
Pure structure refactor — no runtime behavior change; component templates and emit contracts are unchanged.
ConversationPane.vue: collapsed ~42 props into two —vm: ConversationVm(39 view-data fields) andactions: ConversationActions(searchFiles,uploadImage,loadOlderMessages). All 34 emits unchanged.Sidebar.vue: collapsed 9 props into two —vm: SidebarVm(8 client-derived fields) andcolWidth(kept separate; it is layout state, not fromclient). All 13 emits unchanged.App.vuebuildsconversationVm/sidebarVmascomputedobjects mapped one-for-one from the same sources it passed before, plus a stableconversationActionsobject.conversationVmTypes.ts,sidebarVmTypes.ts.The child components read fields via
props.vm.x(reactivity preserved;props.vmis never destructured), so behavior and re-render timing are identical to before.Verified with
typecheck,test(26),build, andoxlint(0 errors) after each subtree.Checklist
apps/kimi-web. Covered bytypecheck+ existing pure-logic tests.)gen-changesetsskill, or this PR needs no changeset. (Patch on@moonshot-ai/kimi-code;@moonshot-ai/kimi-webis ignored and bundled into the CLI.)gen-docsskill, or this PR needs no doc update. (No user-facing behavior change.)