Skip to content

fix(signature): realigning SignatureManager with specs (#284)#290

Draft
guzmud wants to merge 5 commits into
mainfrom
fix/284-realigning-signature_manager
Draft

fix(signature): realigning SignatureManager with specs (#284)#290
guzmud wants to merge 5 commits into
mainfrom
fix/284-realigning-signature_manager

Conversation

@guzmud

@guzmud guzmud commented Jun 16, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • /api/injects/execution/callback/{injectId} as the targeted endpoint
  • realign POST outer envelope
    • reintroducing SignatureTarget model
    • create type InjectExecutionActions (mirroring https://github.com/OpenAEV-Platform/openaev/blob/bba8f2f2180f1a789f7be84144bc2562b62b93e6/openaev-api/src/main/java/io/openaev/rest/inject/form/InjectExecutionAction.java#L3) for the POST outer envelope execution_action
    • create class SignatureOutputStructure to validate the json dumped string that will be in the updated SignatureCallbackPayload
    • add execution_output_structured to the POST outer envelope (typing: str but actually a json dumps of SignatureOutputStructure)
    • generate SignatureOutputStructure, fill it, then serialize it as a str and feed it into the SignatureCallbackPayload
    • add execution_message to the POST outer envelope (typing: str) and fill it using ...?
    • move execution_status to the POST outer envelope (typing: str) and fill it using ...?
    • add execution_duration to the POST envelope (based on the start_time and end_time signatures?)
    • ...
  • replace chunking solution with a more straightforward iterative approach
  • withdraw external injector type related elements

Testing Instructions

  1. ...?

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Jun 16, 2026
@Filigran-Automation

Copy link
Copy Markdown
Contributor

🤖 [AI-generated]

Hey @guzmud! 👋 Thanks a lot for opening PR #290 — really appreciate the contribution to OpenAEV! 🙏

I just had a quick look and I think the description could be enhanced a little to help reviewers get through it faster. I haven't changed anything in your description — just a gentle, optional suggestion:

Area What could help Suggestion
Proposed changes Section is still the empty template (* stubs) A couple of bullets on what was realigned in SignatureManager and why
Testing Instructions Still the placeholder steps Note how to verify (e.g. which scenarios/tests to run)
Related issues Closes #ISSUE-NUMBER placeholder is unfilled Replace with the linked issue, e.g. Closes #284 (every PR should be linked to an issue)

💡 If helpful, the contribution conventions / PR template walk through what to include.

No rush at all — thanks again for contributing to the project! 🚀

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.23%. Comparing base (fafa20a) to head (71fb0ba).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pyoaev/signatures/signature_manager.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   73.19%   73.23%   +0.04%     
==========================================
  Files          53       53              
  Lines        2350     2361      +11     
==========================================
+ Hits         1720     1729       +9     
- Misses        630      632       +2     
Flag Coverage Δ
connectors 73.23% <86.36%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(signature): realigning SignatureManager with specs

3 participants