You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for taking the initiative on this. I will take a closer look later this week when I have some more time. An initial concern I have that using all_parameters and all_variables could easily lead to silent modeling errors. Is there a reason to not have the user more explicitly indicate what variables/parameters should be used?
A good example would be the API used by MathOptAI.
I think all_variables is fine, even if every variable is not an input to each function. I agree all_parameters should be changed to take the specific infinite parameter as a function input so that we aren't using the wrong one incorrectly, if/when there are multiple. We could also make the user inputs more explicit, but I'm not sure if it is necessary when they define the appropriate variables in advance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.