Update Flask serving command and fix typo in app.py#706
Merged
darrylong merged 4 commits intoJun 23, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Cornac’s model-serving instructions and clarifies the serving app’s startup log output for the remove_seen query parameter.
Changes:
- Update README serving command to use
flask --app cornac.serving.appinstead ofFLASK_APP=.... - Fix quoting/whitespace in the serving app’s “remove seen items” startup message.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updates the documented Flask run command for serving a saved model. |
| cornac/serving/app.py | Fixes a typo in the startup log message describing remove_seen=true. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qtuantruong
approved these changes
Jun 21, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
darrylong
changed the title
darrylong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the Flask serving command in the README to use Flask's newer --app flag instead of the deprecated FLASK_APP environment variable. Also fixes a typo in app.py where a single quote was missing before remove_seen=true in the log message, and removes trailing whitespace in the same string.
Related Issues
N/A
Checklist:
README.md(if you are adding a new model).examples/README.md(if you are adding a new example).datasets/README.md(if you are adding a new dataset).