CORE-4588 - add deployment labels to docker image#155
Draft
monotek wants to merge 1 commit into
Draft
Conversation
Signed-off-by: André Bauer <andre.bauer@staffbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Deployment-tracking image labels + configurable metadata namespace
Adds deployment-tracking labels on the built Docker image, mirroring the existing GitOps manifest annotations, and makes both independently toggleable and their key namespace configurable.
What changed
deployment-labelsinput (defaulttrue): stampscom.staffbase.deploy.repositoryFullName/commitSha/versiononto the built image, using the same values as the annotations.deployment-annotationsinput (defaulttrue): the existing annotation behavior, now opt-out.deployment-domaininput (defaultdeploy.staffbase.com): single source of truth for the key namespace — applied verbatim to annotation keys (<domain>/…) and reversed to reverse-DNS for label keys (com.staffbase.deploy.…).Implementation
reverse_domainhelper incommon.sh; dedicatedgenerate-label-prefix.sh+ step (keepsgenerate-tags.shtag-only).gitops-functions.sh.Notes
Docs updated in
README.md.Checklist