Skip to content

chore: track the agent context files and thin out the repo root#785

Merged
Shieldxx merged 1 commit into
mainfrom
chore/784-track-agent-files-thin-root
Jul 26, 2026
Merged

chore: track the agent context files and thin out the repo root#785
Shieldxx merged 1 commit into
mainfrom
chore/784-track-agent-files-thin-root

Conversation

@Shieldxx

Copy link
Copy Markdown
Collaborator

Track the agent context files

AGENTS.md and CLAUDE.md were gitignored under "AI agent context (local only)". They carry architecture facts that agents act on, which makes that the wrong shelf: drift in them is invisible to review, unfixable by a pull request, and free to differ between clones.

That is not hypothetical. #698 recorded four wrong claims in CLAUDE.md that had survived for months, and when I opened a PR to fix them the review bot pointed out the file was not in the diff and could not be. The corrections had to be applied to an untracked local copy.

The original reason for hiding them has also expired: the last 100 commits carry 119 Co-Authored-By: Claude trailers, so AI assistance is already visible to anyone who opens the history.

Corrected before publishing

Fix Why
Dropped the ../internal-docs/... pointer from both It points into a private repo: a dead link for any external reader, and it leaks internal layout. The guidance it pointed at is already inlined directly above it
Commit-message rule in both Both claimed .githooks/commit-msg enforces Conventional Commits. It enforces an issue reference (#N) with a docs: exemption; Conventional Commits are enforced on the PR title by pr-title.yml. Verified by reading the hook
AGENTS.md registry paths Still sent readers to lib/config.ts for GAMES / UTILITIES. They are in src/shared/domain/registries.ts, and it is BUILT_IN_UTILITIES. Same drift #698 recorded for CLAUDE.md
AGENTS.md add-a-game recipe Now states the derived-KNOWN_GAME_KEYS property, so the old two-step recipe cannot come back

Thin out the root

20 files in the root put the README a long scroll down. CONTRIBUTING.md, CODE_OF_CONDUCT.md and SECURITY.md move to .github/, which GitHub resolves exactly as it does the root: the Contributing / Code of conduct / Security entries in the sidebar are unchanged. README's three relative links are updated; the moved files contain no relative links of their own (checked).

Net: 20 files to 17, even after adding the two agent files.

SimLauncher.ico deliberately stays. electron-builder.yml copies it as an extra resource and src/main/window.ts:145 resolves it at runtime with different paths for packaged and dev builds. That is real breakage, only catchable by an installed smoke test, for one line of tidiness.

Test plan

  • format:check · lint · typecheck · build
  • npm run test (563 pass)
  • git grep internal-docs over tracked files returns nothing
  • grep for the three moved filenames repo-wide: only the README links, now updated
  • After merge, confirm the repo sidebar still shows Contributing / Code of conduct / Security, and that the README links resolve on GitHub

No runtime code changed, so there is nothing to add to the 1.2.0 smoke test.

Closes #784

AGENTS.md and CLAUDE.md were gitignored as "AI agent context (local only)".
They carry architecture facts agents act on, so drift in them was invisible to
review, unfixable by a pull request, and free to differ between clones: #698
found four wrong claims in CLAUDE.md that had survived months, and that fix
could not go through a PR at all. The reason for hiding them no longer holds
either, since the last 100 commits carry 119 Co-Authored-By: Claude trailers.

Corrected in both before publishing:
- Dropped a pointer to ../internal-docs, a private repo. Dead link for any
  external reader, and the guidance it pointed at is already inlined above it.
- Both claimed the commit-msg hook enforces Conventional Commits. It enforces an
  issue reference, with a docs: exemption; Conventional Commits are enforced on
  the PR title by pr-title.yml.
- AGENTS.md still sent readers to lib/config.ts for GAMES/UTILITIES, the same
  drift #698 recorded for CLAUDE.md.

Root goes from 20 files to 17 even after adding those two: GitHub resolves the
community-health files from .github/ exactly as from the root, with the same
sidebar entries. SimLauncher.ico deliberately stays put; electron-builder copies
it as an extra resource and window.ts resolves it differently for packaged and
dev builds, which is real risk for one line of tidiness.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@stashpeak-review-bot stashpeak-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Review Bot

🏷 config 🕐 ~2-5 min 🐞 0 🔐 0 🧪 0 📏 0

The diff under review is a trivial .gitignore change that removes the ignore entries for AGENTS.md and CLAUDE.md and replaces them with an explanatory comment, so those two files become tracked. This is a non-behavioral, docs/config-only change with no runtime code touched and no interaction with the repo's process-spawn, kill, or IPC-contract rules. Verified against the actual repository state that AGENTS.md and CLAUDE.md are now tracked, consistent with the PR description.

Walkthrough (1 file)
File Note
.gitignore Removes the ignore rules for AGENTS.md/CLAUDE.md and adds a comment explaining they are now intentionally tracked, so agent context docs go through normal review.

Total: $0.0170 (plus subscription)

Full-lane cost

Review bot usage

mode engine model tokens in tokens out cost time comments
full claude-code claude (subscription) 8 1908 sub 26426 ms 0
shadow api x-ai/grok-4.5 3200 1490 $0.0151 26362 ms 1
shadow api deepseek/deepseek-v4-flash 3004 452 $0.0005 8246 ms 0
shadow api xiaomi/mimo-v2.5 3231 3115 $0.0013 33327 ms 0
shadow api nvidia/nemotron-3-ultra-550b-a55b:free 3068 989 $0.0000 12400 ms 0
shadow-verify api-agentic nvidia/nemotron-3-ultra-550b-a55b:free 29977 955 $0.0000 46228 ms 2

@Stashpeak Stashpeak deleted a comment from coderabbitai Bot Jul 26, 2026
@Shieldxx

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: ac9635d994

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Shieldxx
Shieldxx merged commit 7d5ad39 into main Jul 26, 2026
10 checks passed
@Shieldxx
Shieldxx deleted the chore/784-track-agent-files-thin-root branch July 26, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: track the agent context files and thin out the repo root

1 participant