node shmem: Reset Sample::signals before writing to shared memory#1020
Open
leonardocarreras wants to merge 1 commit into
Open
node shmem: Reset Sample::signals before writing to shared memory#1020leonardocarreras wants to merge 1 commit into
leonardocarreras wants to merge 1 commit into
Conversation
stv0g
requested changes
Jul 16, 2026
stv0g
left a comment
stv0g
left a comment
Contributor
There was a problem hiding this comment.
I believe this change is better located in shmem_int_write:
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
leonardocarreras
force-pushed
the
fix-shmem-sample-signal
branch
from
July 16, 2026 10:10
3a51577 to
f27f241
Compare
Contributor
Author
Hi @stv0g, I agree with your suggestion. I moved it there and tested again. Thanks also for the style comments. |
stv0g
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shmem node writes samples whose
signalsfield is astd::shared_ptrinto the writer's heap. A reader in another process dereferences that pointer while copying the sample and crashes.Discovered when using two villas-node processes with shmem, it segfaults at the first read.