Merge base/mod script compilation into a single _RunMake()#98
Open
marlonrichert wants to merge 1 commit into
Open
Merge base/mod script compilation into a single _RunMake()#98marlonrichert wants to merge 1 commit into
marlonrichert wants to merge 1 commit into
Conversation
_RunMakeBase() and _RunMakeMod() each invoked `make` separately, but `make -mods <name> <path>` already recompiles base-game script packages as part of compiling the mod's own package.
marlonrichert
marked this pull request as draft
July 14, 2026 09:21
Contributor
Author
|
Let's hold off on this one. I seem to have introduced a bug. |
marlonrichert
marked this pull request as ready for review
July 14, 2026 12:40
Contributor
Author
|
The problem is not in this one. It's in #96. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_RunMakeBase() and _RunMakeMod() each invoked
makeseparately, butmake -mods <name> <path>already recompiles base-game script packages as part of compiling the mod's own package.