feat(notification): add interval for new question emails#1545
Open
AsyncAssassin wants to merge 1 commit into
Open
feat(notification): add interval for new question emails#1545AsyncAssassin wants to merge 1 commit into
AsyncAssassin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configurable interval between email send attempts for new-question / followed-tag notification fan-out.
The interval is controlled by
NEW_QUESTION_NOTIFICATION_EMAIL_SEND_INTERVAL_SECONDS.The default is
0, so the current behavior is preserved unless the environment variable is explicitly set. Empty, invalid, negative, or overflowing values also fall back to0.Scope
This is based on the scope discussed in #625 and confirmed by @LinkinStars.
This PR only applies the delay to new-question notification email fan-out. It does not change:
EmailService.SendWhen the interval is enabled, plugin notifications are sent before the throttled email fan-out, so they are not delayed by the configured sleep.
Tests
Added focused tests for:
Validation: