Skip to content

[fix](fe)add needForward for PARALLEL_EXCHANGE_INSTANCE_NUM and LOAD_STREAM_PER_NODE to take effect in insert select#64626

Open
lzydmxy wants to merge 1 commit into
apache:masterfrom
lzydmxy:fix_add_needForward
Open

[fix](fe)add needForward for PARALLEL_EXCHANGE_INSTANCE_NUM and LOAD_STREAM_PER_NODE to take effect in insert select#64626
lzydmxy wants to merge 1 commit into
apache:masterfrom
lzydmxy:fix_add_needForward

Conversation

@lzydmxy

@lzydmxy lzydmxy commented Jun 18, 2026

Copy link
Copy Markdown

What problem does this PR solve?

Problem Summary:

When executing INSERT SELECT on a non-master FE, the statement is forwarded to the master
FE via ForwardWithSync. During forwarding, only session variables annotated with
needForward=true are propagated. Two session variables used during LOAD execution were
missing this annotation, causing them to always use default values on the master FE:

  1. parallel_exchange_instance_num — controls Fragment 0 (OLAP_TABLE_SINK) instance count.
    UnassignedShuffleJob.degreeOfParallelism() reads this from
    statementContext.getConnectContext() during planning on the master FE. Without needForward,
    Fragment 0 always defaults to 256 instances regardless of SET value.

  2. load_stream_per_node — controls per-BE load stream concurrency for OLAP_TABLE_SINK.
    ThriftPlansBuilder.setParamsForOlapTableSink() reads this on the master FE during LOAD
    execution. Without needForward, it always defaults to 2.

The root cause pattern is that these variables are used during FE-side planning/execution
on the master FE node (after forwarding), not just on the original client FE. The
ForwardWithSync mechanism only propagates variables marked needForward=true, so the
master FE never sees the user-configured values.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…AM_PER_NODE to take effect in insert select
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@lzydmxy lzydmxy changed the title fix: add needForward for PARALLEL_EXCHANGE_INSTANCE_NUM and LOAD_STREAM_PER_NODE to take effect in insert select [fix](fe)add needForward for PARALLEL_EXCHANGE_INSTANCE_NUM and LOAD_STREAM_PER_NODE to take effect in insert select Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants