[fix](fe)add needForward for PARALLEL_EXCHANGE_INSTANCE_NUM and LOAD_STREAM_PER_NODE to take effect in insert select#64626
Open
lzydmxy wants to merge 1 commit into
Open
Conversation
…AM_PER_NODE to take effect in insert select
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When executing INSERT SELECT on a non-master FE, the statement is forwarded to the master
FE via ForwardWithSync. During forwarding, only session variables annotated with
needForward=true are propagated. Two session variables used during LOAD execution were
missing this annotation, causing them to always use default values on the master FE:
parallel_exchange_instance_num— controls Fragment 0 (OLAP_TABLE_SINK) instance count.UnassignedShuffleJob.degreeOfParallelism() reads this from
statementContext.getConnectContext() during planning on the master FE. Without needForward,
Fragment 0 always defaults to 256 instances regardless of SET value.
load_stream_per_node— controls per-BE load stream concurrency for OLAP_TABLE_SINK.ThriftPlansBuilder.setParamsForOlapTableSink() reads this on the master FE during LOAD
execution. Without needForward, it always defaults to 2.
The root cause pattern is that these variables are used during FE-side planning/execution
on the master FE node (after forwarding), not just on the original client FE. The
ForwardWithSync mechanism only propagates variables marked needForward=true, so the
master FE never sees the user-configured values.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)