Skip to content

branch-4.1: [Exec](status) materialization_opertor return the error status by row_id_fetcher #62513#64628

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-62513-branch-4.1
Jun 20, 2026
Merged

branch-4.1: [Exec](status) materialization_opertor return the error status by row_id_fetcher #62513#64628
yiguolei merged 1 commit into
branch-4.1from
auto-pick-62513-branch-4.1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #62513

…_id_fetcher (#62513)

Problem Summary:
- MaterializationOperator did not check
rpc_struct.response.status().status_code after row_id_fetcher RPCs, so
backend-side errors were not propagated to the caller.
- This change verifies the RPC response status; if status_code != 0, it
constructs an error message containing backend id, status_code,
error_msg and the Materialization Sink node id, and returns
Status::InternalError so the error is reported upstream.
@github-actions github-actions Bot requested a review from yiguolei as a code owner June 18, 2026 07:51
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 16.67% (1/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.76% (27424/37180)
Line Coverage 57.38% (297174/517888)
Region Coverage 55.04% (249547/453380)
Branch Coverage 56.46% (108095/191448)

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jun 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

@yiguolei

Copy link
Copy Markdown
Contributor

skip buildall

@yiguolei yiguolei merged commit 73de3f5 into branch-4.1 Jun 20, 2026
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants