branch-4.1: [fix](cloud) Recycle empty rowsets without resource id #64630#64643
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](cloud) Recycle empty rowsets without resource id #64630#64643github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
When recycling a dropped tablet, empty rowsets may have `num_segments == 0` and an empty `resource_id`. The protobuf field can be explicitly set to an empty string, so `has_resource_id()` returns true. The recycler then attempts to look up an accessor for the empty ID, fails the recycle round, and repeatedly leaves the dropped tablet/index metadata behind. This PR skips object deletion for every rowset with zero segments because it has no segment objects to remove. Rowsets with segments still require a non-empty resource ID.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64630