Skip to content

FINERACT-2455: WC - Delinquency Pause Resume#5969

Open
mariiaKraievska wants to merge 2 commits into
apache:developfrom
openMF:FINERACT-2455/working-capital-delinquency-pause-resume
Open

FINERACT-2455: WC - Delinquency Pause Resume#5969
mariiaKraievska wants to merge 2 commits into
apache:developfrom
openMF:FINERACT-2455/working-capital-delinquency-pause-resume

Conversation

@mariiaKraievska

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-delinquency-pause-resume branch from 5822755 to f3f99ed Compare June 10, 2026 12:56

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


private void validateResumeStartDate(final WorkingCapitalLoanDelinquencyAction action, final LocalDate businessDate) {
if (action.getStartDate() == null) {
raiseValidationError("wc-loan-delinquency-action-resume-startDate-cannot-be-blank", "The parameter `startDate` is mandatory",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error format is wc-loan-delinquency-action-resume-startDate-cannot-be-blank, not wc.loan.delinquency.action.resume.startDate.cannot.be.blank, when using DataValidatorBuilder. I think DataValidatorBuilder is the better approach.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oleksii-novikov-onix, I reworked all WorkingCapitalLoanDelinquencyActionParseAndValidator to use DataValidatorBuilder. But we also have such error format like "loan-delinquency-action-..." in DelinquencyActionParseAndValidator for basic loans, @adamsaghy maybe we should rework this also in some separate PR? What do you think? This is the only place where, for some reason, this format was chosen, everywhere else, it's separated by a "."

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamsaghy @oleksii-novikov-onix here is a PR with error format refactoring for basic loan #5995

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-delinquency-pause-resume branch from cdc8882 to 1a0e499 Compare June 17, 2026 09:22
@ruzeynalov ruzeynalov force-pushed the FINERACT-2455/working-capital-delinquency-pause-resume branch from 1a0e499 to 595902a Compare June 17, 2026 11:32
@mariiaKraievska mariiaKraievska marked this pull request as ready for review June 17, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants