FINERACT-2455: WC - Delinquency Pause Resume#5969
Conversation
5822755 to
f3f99ed
Compare
|
|
||
| private void validateResumeStartDate(final WorkingCapitalLoanDelinquencyAction action, final LocalDate businessDate) { | ||
| if (action.getStartDate() == null) { | ||
| raiseValidationError("wc-loan-delinquency-action-resume-startDate-cannot-be-blank", "The parameter `startDate` is mandatory", |
There was a problem hiding this comment.
The error format is wc-loan-delinquency-action-resume-startDate-cannot-be-blank, not wc.loan.delinquency.action.resume.startDate.cannot.be.blank, when using DataValidatorBuilder. I think DataValidatorBuilder is the better approach.
There was a problem hiding this comment.
Thank you @oleksii-novikov-onix, I reworked all WorkingCapitalLoanDelinquencyActionParseAndValidator to use DataValidatorBuilder. But we also have such error format like "loan-delinquency-action-..." in DelinquencyActionParseAndValidator for basic loans, @adamsaghy maybe we should rework this also in some separate PR? What do you think? This is the only place where, for some reason, this format was chosen, everywhere else, it's separated by a "."
There was a problem hiding this comment.
@adamsaghy @oleksii-novikov-onix here is a PR with error format refactoring for basic loan #5995
cdc8882 to
1a0e499
Compare
1a0e499 to
595902a
Compare
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.