[FLUSS-3483][coordinator] Validate lake snapshot offsets before commit#3494
Open
Jackeyzhe wants to merge 2 commits into
Open
[FLUSS-3483][coordinator] Validate lake snapshot offsets before commit#3494Jackeyzhe wants to merge 2 commits into
Jackeyzhe wants to merge 2 commits into
Conversation
added 2 commits
June 18, 2026 12:11
Reject V2 lake snapshot commits when the target table no longer exists, is queued for deletion, or the offsets metadata file belongs to a different table id. This prevents stale lake snapshot paths from being written into the recreated table's laketable znode after drop/recreate races. Also add coordinator and RPC tests for dropped tables and mismatched offsets metadata.
Reject V2 lake snapshot commits when the target table no longer exists, is queued for deletion, or the offsets metadata file belongs to a different table id. This prevents stale lake snapshot paths from being written into the recreated table's laketable znode after drop/recreate races. Also add coordinator and RPC tests for dropped tables and mismatched offsets metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3483
This PR fixes a race where a stale V2 lake snapshot commit can be accepted after a table is dropped and recreated. In that case, the recreated table may get a
/laketableznode pointing to an offsets metadata file generated for the old table id, causing lake tiering to repeatedly fail when reading the stale offsets path.Brief change log
tableIdmust match the commit table id;TableBucketin the offsets file must also belong to the commit table id.Tests
mvn -pl fluss-server -DskipITs -Dcheckstyle.skip -Drat.skip -Dspotless.check.skip=true -Dtest=CoordinatorEventProcessorTest#testCommitLakeTableSnapshotV2RejectsMismatchedOffsetsFileTableId+testCommitLakeTableSnapshotV2RejectsNonExistentTable+testCommitLakeTableSnapshotV2RejectsQueuedForDeletionTable testmvn -pl fluss-server -DskipITs -Dcheckstyle.skip -Drat.skip -Dspotless.check.skip=true -Dtest=CommitLakeTableSnapshotITCase#testCommitLakeTableSnapshotV2RejectedAfterDropTable testAPI and Format
no
Documentation
no