[core] Reuse manifest merge results on commit retry#8229
Draft
leaves12138 wants to merge 1 commit into
Draft
Conversation
9785f48 to
5c1550b
Compare
Contributor
|
Sounds no issue to me. |
JingsongLi
reviewed
Jun 18, 2026
| + mergedManifests.size())); | ||
| boolean insertedMergeAfter = false; | ||
| for (ManifestFileMeta currentManifest : currentManifests) { | ||
| int mergeBeforeIndex = remainingMergeBefore.indexOf(currentManifest); |
Contributor
There was a problem hiding this comment.
You can use ListUtils something like list.replaceAll.
e6100f9 to
5f16a12
Compare
5f16a12 to
9c0d773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ManifestFileMerger.mergeand write the latest snapshot data manifests directly as the new base manifest list.ListUtils.tryReplacefor continuous sub-list replacement and use it for manifest replacement.Tests
mvn -pl paimon-common -Pfast-build -Dtest=ListUtilsTest testmvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -Dtest=FileStoreCommitTest#testCommitRetryReusePreviousManifestMergeResultWhenBeforeStillExists+testCommitRetrySkipsManifestMergeWhenBeforeExistsNonContiguously+testCommitRetrySkipsManifestMergeWhenPreviousMergeCannotBeReused+testCommitRetrySkipsManifestMergeAcrossMultipleRetries+testCommitRetryFromEmptyTableWithConcurrentFirstSnapshot+testCommitRetrySkipsManifestMergePreservesDeleteOrder testmvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -Dtest=FileStoreCommitTest testmvn -pl paimon-common,paimon-core -am -DskipTests compilegit diff --check