[core] Fix JDBC connection leak in ClientPool and JdbcCatalog#8268
Open
junmuz wants to merge 1 commit into
Open
[core] Fix JDBC connection leak in ClientPool and JdbcCatalog#8268junmuz wants to merge 1 commit into
junmuz wants to merge 1 commit into
Conversation
junmuz
force-pushed
the
fixing_jdbc_connection_leaks
branch
from
7f16f08 to
05dee59
Compare
Contributor
Author
|
@JingsongLi Can I get a review on the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes the Jdbc connection leaks that happen when Flink TMs restart.
Issue: #8267
Tests
There are some tests added specially the
testConnectionClosedWhenPoolClosedDuringActionthat simulates the scenario.