Harden Pithos archive parsing, extraction, and block handling#35
Merged
Conversation
…ugh normative specification details
…ion, and input validation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 69.07% 76.60% +7.52%
==========================================
Files 17 19 +2
Lines 2985 4154 +1169
==========================================
+ Hits 2062 3182 +1120
- Misses 923 972 +49 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
St4NNi
self-requested a review
July 22, 2026 18:56
St4NNi
approved these changes
Jul 22, 2026
St4NNi
left a comment
Member
There was a problem hiding this comment.
These are quite a few long standing issues that have been fixed. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes hardens
pithos_libacross archive writing, parsing, reading, extraction, and append flows. It addresses multiple correctness and security issues around compression handling, path safety, external block access, malformed archive validation, directory integrity, plaintext integrity checks, header/version validation, and append-time block reuse.What changed
Additional changes
pithos_libintegration tests for writer, reader, marshalling, and robustness scenarios.Testing
pithos_libintegration tests and workspace checks.