fix(desktop): prevent process text truncation#1214
Draft
thomaspblock wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Thomas Petersen <thomasp@squareup.com> Signed-off-by: Thomas Petersen <thomasp@squareup.com>
wesbillman
reviewed
Jun 23, 2026
Comment on lines
+1
to
+12
| import { expect, test, type Page } from "@playwright/test"; | ||
|
|
||
| import { installMockBridge } from "../helpers/bridge"; | ||
| import { waitForAnimations } from "../helpers/animations"; | ||
|
|
||
| const SHOTS = "test-results/process-text"; | ||
| const AGENT_PUBKEY = "ab".repeat(32); | ||
| const AGENT_NAME = | ||
| "Brain process status with a deliberately long operation label that should ellipsize cleanly"; | ||
| const KIND_TYPING_INDICATOR = 20002; | ||
|
|
||
| async function waitForMockLiveSubscription( |
Collaborator
There was a problem hiding this comment.
@thomaspblock do we need the screenshot tests here for this one? It seems like it's adding code and test time, so I want to make sure it's useful.
Collaborator
Author
There was a problem hiding this comment.
This is still a draft. Will add video/screenshot once I am sure it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-w-40capValidation
pnpm --dir desktop typecheckpnpm --dir desktop checkpnpm --dir desktop exec playwright test process-text-screenshots.spec.ts --project=smokeScreenshots
Posted in Buzz thread.