fix(orchestrator): accept schedule-suffixed workflow IDs for the active scan#88
Closed
awolden wants to merge 1 commit into
Closed
fix(orchestrator): accept schedule-suffixed workflow IDs for the active scan#88awolden wants to merge 1 commit into
awolden wants to merge 1 commit into
Conversation
…ve scan
Temporal schedules start the action workflow as "{Action.ID}-{nominal
start time}", so scheduled runs arrive as
version-guard-active-scan-2026-06-11T08:00:00Z and the exact-match
singleton check rejected every scheduled scan (staging produced no
snapshot on 2026-06-11). Match on prefix instead; arbitrary workflow
IDs are still rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The singleton workflow-ID check added in #86's merge ("Enforce singleton orchestrator workflow ID") rejects every schedule-started run: Temporal schedules start the action workflow as
{Action.ID}-{nominal start time}, so the daily scan arrives asversion-guard-active-scan-2026-06-11T08:00:00Zand fails the exact match. Staging's 2026-06-11 08:00 UTC scan failed in 4 seconds and produced no snapshot; manual scans are unaffected since they use the bare ID.What
Generated with Claude Code