Skip to content

fix: integrate updated cds.odata.urlify api#497

Draft
PDT42 wants to merge 1 commit into
mainfrom
fix/integrate-updated-urlify
Draft

fix: integrate updated cds.odata.urlify api#497
PDT42 wants to merge 1 commit into
mainfrom
fix/integrate-updated-urlify

Conversation

@PDT42

@PDT42 PDT42 commented Jul 23, 2026

Copy link
Copy Markdown

An intended update to the internal cds.odata.urlify API will require this change.

@hyperspace-pr-bot

Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Fix: Integrate Updated cds.odata.urlify API

Bug Fix

🐛 Updated the call signature for cds.odata.urlify to match its new internal API, which now requires a structured object containing both query and subject properties instead of a plain query argument.

Changes

  • lib/plugin.js: Updated the cds.odata.urlify invocation to pass an object with { query: SELECT.from(...), subject: { ref: path.concat(compName) } } instead of passing SELECT.from(...) directly. This aligns with the updated internal API contract for cds.odata.urlify.

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.29.2

  • Output Template: Default Template
  • Correlation ID: 99c58e70-869b-11f1-8e8c-1602f2c5df8d
  • Event Trigger: pull_request.opened
  • LLM: anthropic--claude-4.6-sonnet
  • File Content Strategy: Full file content
  • Summary Prompt: Default Prompt

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the diff, the change at line 795 wraps the previously positional SELECT query argument into an object with both query and subject properties to match the updated cds.odata.urlify API signature.

The subject value { ref: path.concat(compName) } mirrors the same expression already used for the query's SELECT.from. This looks structurally consistent and intentional per the PR description ("integrate updated cds.odata.urlify api").

The change is minimal and targeted. The overall quality of this PR is good — it is a small, focused API adaptation with no logic changes beyond adapting to the new cds.odata.urlify signature.

PR Bot Information

Version: 1.29.2

  • Correlation ID: 99c58e70-869b-11f1-8e8c-1602f2c5df8d
  • Event Trigger: pull_request.opened
  • LLM: anthropic--claude-4.6-sonnet
  • File Content Strategy: Full file content
  • Experiment Variant: control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant