fix: increase datasource lagging behind alert time frame to 30 min#1035
Merged
Conversation
SoWieMarkus
requested review from
PhilippMatthes,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesAlert timing
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@helm/bundles/cortex-nova/templates/alerts.yaml`:
- Line 347: Update the alert description annotation associated with the 30m
`for` duration to state that the condition persists for more than 30 minutes
instead of more than 10 minutes. Keep the alert behavior and other annotations
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 523ec40b-99cf-4e40-b1fb-2396b08069f0
📒 Files selected for processing (1)
helm/bundles/cortex-nova/templates/alerts.yaml
juliusclausnitzer
previously approved these changes
Jul 13, 2026
juliusclausnitzer
approved these changes
Jul 13, 2026
Contributor
Test Coverage ReportTest Coverage 📊: 70.1% |
mblos
approved these changes
Jul 13, 2026
Merged
mblos
added a commit
that referenced
this pull request
Jul 13, 2026
## Changelog ### cortex v0.3.0 (sha-ee9cd485) Breaking changes: - `NumberOfObjects` field in `DatasourceStatus` changed from `int64` to `*int64` so `omitempty` no longer strips zero values ([#1024](#1024)) Non-breaking changes: - Migrate CR and failover calls to options-based pipeline selection — eliminates dedicated CR and failover pipelines by encoding behavioral differences as call-time scheduling options ([#950](#950)) - Convert capacity controller from timer-based to controller-runtime reconciler with reactive watches and coalesced reconcile keys ([#1025](#1025)) - Split quota enforcement `accept_skipped` decision into sub-buckets for granular observability ([#1022](#1022)) - Fix alert wording: 'LackingBehind' → 'LaggingBehind' ([#1031](#1031)) - Increase datasource lagging behind alert time frame to 30 min ([#1035](#1035)) - Add logger context for remote cluster communication ([#1023](#1023)) - Update `golang.org/x/sync` v0.21.0→v0.22.0, `golang.org/x/term` v0.44.0→v0.45.0 ([#1026](#1026)) - Update `ironcore` v0.4.2→v0.4.3 ([#1029](#1029)) - Update `github.com/sapcc/go-bits` ([#1030](#1030)) ### cortex-shim v0.1.6 (sha-ee9cd485) Includes updated image sha-ee9cd485. ### cortex-nova v0.0.80 Includes updated charts cortex v0.3.0, cortex-postgres v0.6.8. - Scope `SyncObjectsDroppedToZero` alert to only fire when previously non-zero ([#1024](#1024)) - Add `capacityMinReconcileInterval` config key for capacity controller ([#1025](#1025)) ### cortex-cinder v0.0.80 Includes updated charts cortex v0.3.0, cortex-postgres v0.6.8. - Scope `SyncObjectsDroppedToZero` alert to only fire when previously non-zero ([#1024](#1024)) ### cortex-manila v0.0.80 Includes updated charts cortex v0.3.0, cortex-postgres v0.6.8. - Scope `SyncObjectsDroppedToZero` alert to only fire when previously non-zero ([#1024](#1024)) ### cortex-crds v0.0.80 Includes updated chart cortex v0.3.0. ### cortex-ironcore v0.0.80 Includes updated chart cortex v0.3.0. ### cortex-pods v0.0.80 Includes updated chart cortex v0.3.0. ### cortex-placement-shim v0.1.6 Includes updated chart cortex-shim v0.1.6. ## Dependencies - Bump PR: #1038 (must be merged before this PR) - Changelog PR: #1039 (merge after this PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.