Add native histogram support to all remaining production histograms#7636
Open
CharlieTLe wants to merge 4 commits into
Open
Add native histogram support to all remaining production histograms#7636CharlieTLe wants to merge 4 commits into
CharlieTLe wants to merge 4 commits into
Conversation
Convert ~45 remaining classic-only histograms to dual-format (classic + native) by adding NativeHistogramBucketFactor, NativeHistogramMaxBucketNumber, and NativeHistogramMinResetDuration fields. This follows the same pattern already established for ~11 histograms in the codebase. Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
dosubot
Bot
added
type/feature
type/observability
SungJin1212
reviewed
Jun 23, 2026
| * [ENHANCEMENT] Distributor: Add `WrappedHistogram` with configurable size limit (`-validation.max-native-histogram-size-bytes`) to cap native histogram protobuf size before unmarshalling. #7570 | ||
| * [ENHANCEMENT] Ingester: Add lazy regex evaluation on head postings cache miss. Defers expensive regex matchers on high-cardinality labels to per-series filtering when a selective equality matcher already narrows the result set. Configured via `-blocks-storage.expanded_postings_cache.head.lazy-matcher-max-cardinality` (disabled by default). #7553 | ||
| * [ENHANCEMENT] Ring: Add ring metric to count number of duplicate tokens. #7626 | ||
| * [ENHANCEMENT] Metrics: Add native histogram support to all remaining production histograms, enabling dual-format (classic + native) exposition across all Cortex components. |
Member
There was a problem hiding this comment.
Thanks, can you add a PR number?
SungJin1212
approved these changes
Jun 23, 2026
Signed-off-by: Charlie Le <charlie_le@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Convert ~45 remaining classic-only histograms to dual-format (classic +
native) by adding NativeHistogramBucketFactor, NativeHistogramMaxBucketNumber,
and NativeHistogramMinResetDuration fields. This follows the same pattern
already established for ~11 histograms in the codebase.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags