#1909: create commandlet for mvnd#2061
Open
AdemZarrouki wants to merge 18 commits into
Open
Conversation
…fter introducing mvnd
Collaborator
Coverage Report for CI Build 28230297567Coverage increased (+0.1%) to 71.472%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions25 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
tineff96
reviewed
Jun 23, 2026
tineff96
reviewed
Jun 23, 2026
Contributor
There was a problem hiding this comment.
Thanks, this looks good overall. mvnd is registered as a commandlet, the NLS/help text is present, the shared MavenCommandlet extraction looks reasonable, and the full test suite passes locally for me.
I ran:
mvn clean testI left one inline comment about the mvnd dependency metadata. I think this should be fixed before merging, because Java is currently not ensured as a dependency for mvnd 1.0.6.
Two smaller follow-ups:
- The test fixture should probably use
MVND_VERSION=1.0.6instead ofMVN_VERSION=1.0.6. - The testing instructions contain small copy/paste issues:
mvnd--helpshould probably bemvnd --help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1909
Implemented changes:
mvndtool commandletmvndcommands/optionsMavenCommandletmvndIdeCompleterTestfor ambiguous mvn/mvnd prefix.CompleteTestformvndTesting instructions
ide --help-> in the listed commandletmvndshould be presentide install mvnd-> tool should be installed successfullymvnd --version-> the version installe dshould be displayedmvnd --help-> should display the right arguments to use with the toolmvndChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalChecklist for tool commandlets
Have you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandlet