Skip to content

#1689: fix misleading message in set-version when version is already installed#2078

Open
Ali-Shariati-Najafabadi wants to merge 1 commit into
devonfw:mainfrom
Ali-Shariati-Najafabadi:feature/1689-fix-set-version-cli-message
Open

#1689: fix misleading message in set-version when version is already installed#2078
Ali-Shariati-Najafabadi wants to merge 1 commit into
devonfw:mainfrom
Ali-Shariati-Najafabadi:feature/1689-fix-set-version-cli-message

Conversation

@Ali-Shariati-Najafabadi

@Ali-Shariati-Najafabadi Ali-Shariati-Najafabadi commented Jun 26, 2026

Copy link
Copy Markdown

This PR fixes #1689

Implemented changes

  • Updated setVersion method in ToolCommandlet.java to check if the
    requested version is already installed before showing the install hint
  • If version is already installed: show confirmation message instead of
    misleading install instruction

Checklist for this PR

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary»
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled with internal

@CLAassistant

CLAassistant commented Jun 26, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Ali-Shariati-Najafabadi Ali-Shariati-Najafabadi added enhancement New feature or request logging IDEasy specific logging (levels, messages, etc.) bugfix PR that fixes a bug issue labels Jun 26, 2026
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 28236116824

Coverage increased (+0.03%) to 71.39%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 14 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

14 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/ToolCommandlet.java 14 73.87%

Coverage Stats

Coverage Status
Relevant Lines: 16276
Covered Lines: 12115
Line Coverage: 74.43%
Relevant Branches: 7286
Covered Branches: 4706
Branch Coverage: 64.59%
Branches in Coverage %: Yes
Coverage Strength: 3.15 hits per line

💛 - Coveralls

@Ali-Shariati-Najafabadi Ali-Shariati-Najafabadi moved this from 🆕 New to Team Review in IDEasy board Jun 26, 2026
@Ali-Shariati-Najafabadi Ali-Shariati-Najafabadi changed the title #1689: fix misleading message in set-version when version is already … #1689: fix misleading message in set-version when version is already installed Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue enhancement New feature or request logging IDEasy specific logging (levels, messages, etc.)

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Fix user commnication when switching the Java version from the default to the required one

3 participants