server: remove verifySnapshotIndex assertion

[henrybear327]

Ref: #20426

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.58%. Comparing base (e9b62f8) to head (b028690).

Additional details and impacted files

Files with missing lines	Coverage Δ
server/etcdserver/server.go	83.69% <ø> (-0.56%)	⬇️
server/etcdserver/snapshot_merge.go	77.77% <ø> (-0.61%)	⬇️

... and 31 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21925      +/-   ##
==========================================
- Coverage   69.76%   69.58%   -0.18%     
==========================================
  Files         449      449              
  Lines       38208    38199       -9     
==========================================
- Hits        26656    26581      -75     
- Misses      10126    10189      +63     
- Partials     1426     1429       +3     

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b62f8...b028690. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[serathius]

/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henrybear327, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[serathius]

/cc @fuweid

[serathius]

/retest

[henrybear327]

/retest

[henrybear327]

Hey @serathius, quick question, is this verifier causing any performance or other types of issue, such that we would like to have it removed?

I was just checking around, and wondering, if we removed this check, how are we able to catch this issue again in the future if the bug slipped in.

Thank you!

[k8s-ci-robot]

@henrybear327: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-unit-test-386	b028690	link	true	/test pull-etcd-unit-test-386
pull-etcd-coverage-report	b028690	link	true	/test pull-etcd-coverage-report
pull-etcd-e2e-amd64	b028690	link	true	/test pull-etcd-e2e-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.