Skip to content

feat: move reupload command to root level#774

Draft
Riki0923 wants to merge 2 commits into
masterfrom
feat/root-level-reupload
Draft

feat: move reupload command to root level#774
Riki0923 wants to merge 2 commits into
masterfrom
feat/root-level-reupload

Conversation

@Riki0923

@Riki0923 Riki0923 commented Jul 9, 2026

Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Comment thread src/command/reupload.ts Outdated
})
}
} catch (error) {
this.console.printBeeError(error, { notFoundMessage: 'No locally pinned content found with that address.' })

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message no longer makes sense as a root level command.
Something like "No content found with that address." would be better.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Cafe137 Cafe137 Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change. Our coverage tracking works in mysterious ways 😅 But it shouldn't be committed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restored to the master branch's version

Comment thread README.md Outdated
Comment thread swarm.png Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@Cafe137 Cafe137 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test, the functionality looks good.

Most of the comments are about removing the unrelated files that were committed.

The rest are about changing copies that still refer to pinning, which is not a requirement anymore for this command. Please also change the description field of the command to "Reupload and restamp content on the network"

@Riki0923

Riki0923 commented Jul 12, 2026

Copy link
Copy Markdown
Author

Thanks for adding the test, the functionality looks good.

Most of the comments are about removing the unrelated files that were committed.

The rest are about changing copies that still refer to pinning, which is not a requirement anymore for this command. Please also change the description field of the command to "Reupload and restamp content on the network"

description field changed

@github-actions

Copy link
Copy Markdown
Contributor
File Coverage Now Coverage Before Delta% Rating
Total 2593 / 3164 2583 / 3160 0.21 🟢
application.ts 0 / 2 0 / 2 0.00
config.ts 32 / 33 31 / 32 0.09 🟢
curl.ts 24 / 24 24 / 24 0.00
index.ts 0 / 16 0 / 16 0.00
printer.ts 3 / 7 3 / 7 0.00
command/addresses.ts 32 / 37 32 / 37 0.00
command/download.ts 29 / 36 29 / 36 0.00
command/hash.ts 8 / 10 8 / 10 0.00
command/quickstart.ts 35 / 38 35 / 38 0.00
command/reupload.ts 19 / 21 0 / 0 90.48 🟢
command/status.ts 81 / 81 81 / 81 0.00
command/upload.ts 206 / 266 206 / 266 0.00
command/access/access-command.ts 2 / 2 2 / 2 0.00
command/access/grant.ts 31 / 31 31 / 31 0.00
command/access/history.ts 28 / 31 28 / 31 0.00
command/access/index.ts 10 / 10 10 / 10 0.00
command/access/init.ts 27 / 27 27 / 27 0.00
command/access/list.ts 15 / 15 15 / 15 0.00
command/access/revoke.ts 31 / 31 31 / 31 0.00
command/access/show.ts 23 / 23 23 / 23 0.00
command/cheque/cashout.ts 30 / 32 30 / 32 0.00
command/cheque/cheque-command.ts 21 / 25 21 / 25 0.00
command/cheque/deposit.ts 16 / 16 16 / 16 0.00
command/cheque/index.ts 9 / 9 9 / 9 0.00
command/cheque/list.ts 13 / 13 13 / 13 0.00
command/cheque/withdraw-all.ts 6 / 15 6 / 15 0.00
command/cheque/withdraw.ts 16 / 16 16 / 16 0.00
command/feed/feed-command.ts 55 / 55 55 / 55 0.00
command/feed/index.ts 7 / 7 7 / 7 0.00
command/feed/print.ts 26 / 80 26 / 80 0.00
command/feed/update.ts 14 / 15 14 / 15 0.00
command/feed/upload.ts 26 / 28 26 / 28 0.00
command/history/disable.ts 18 / 18 18 / 18 0.00
command/history/enable.ts 15 / 15 15 / 15 0.00
command/history/history-command.ts 2 / 2 2 / 2 0.00
command/history/index.ts 9 / 9 9 / 9 0.00
command/history/list.ts 17 / 17 17 / 17 0.00
command/history/show.ts 26 / 28 26 / 28 0.00
command/history/status.ts 16 / 16 16 / 16 0.00
command/identity/create.ts 36 / 41 36 / 41 0.00
command/identity/export.ts 20 / 22 20 / 22 0.00
command/identity/identity-command.ts 21 / 27 21 / 27 0.00
command/identity/import.ts 50 / 63 50 / 63 0.00
command/identity/index.ts 11 / 11 11 / 11 0.00
command/identity/list.ts 21 / 21 21 / 21 0.00
command/identity/remove.ts 15 / 21 15 / 21 0.00
command/identity/rename.ts 16 / 16 16 / 16 0.00
command/identity/show.ts 27 / 33 27 / 33 0.00
command/manifest/add.ts 38 / 39 38 / 39 0.00
command/manifest/create.ts 16 / 17 16 / 17 0.00
command/manifest/download.ts 46 / 47 46 / 47 0.00
command/manifest/index.ts 11 / 11 11 / 11 0.00
command/manifest/list.ts 40 / 42 40 / 42 0.00
command/manifest/merge.ts 24 / 25 24 / 25 0.00
command/manifest/remove.ts 26 / 29 26 / 29 0.00
command/manifest/sync.ts 49 / 50 49 / 50 0.00
command/pinning/index.ts 8 / 8 9 / 9 0.00
command/pinning/list.ts 14 / 14 14 / 14 0.00
command/pinning/pin.ts 10 / 11 10 / 11 0.00
command/pinning/pinning-command.ts 5 / 8 5 / 8 0.00
command/pinning/reupload-all.ts 21 / 23 21 / 23 0.00
command/pinning/unpin.ts 11 / 11 11 / 11 0.00
command/pss/index.ts 7 / 7 7 / 7 0.00
command/pss/pss-command.ts 8 / 8 8 / 8 0.00
command/pss/receive.ts 18 / 24 18 / 24 0.00
command/pss/send.ts 29 / 34 29 / 34 0.00
command/pss/subscribe.ts 8 / 18 8 / 18 0.00
command/root-command/command-config.ts 35 / 41 35 / 41 0.00
command/root-command/command-log.ts 65 / 78 65 / 78 0.00
command/root-command/index.ts 48 / 52 48 / 52 0.00
command/root-command/printer.ts 9 / 9 9 / 9 0.00
command/stake/deposit.ts 30 / 45 30 / 45 0.00
command/stake/index.ts 8 / 8 8 / 8 0.00
command/stake/recover.ts 10 / 22 10 / 22 0.00
command/stake/status.ts 11 / 11 11 / 11 0.00
command/stake/withdraw.ts 7 / 25 7 / 25 0.00
command/stamp/buy.ts 50 / 64 50 / 64 0.00
command/stamp/create.ts 18 / 72 18 / 72 0.00
command/stamp/dilute.ts 12 / 27 12 / 27 0.00
command/stamp/extend.ts 10 / 51 10 / 51 0.00
command/stamp/index.ts 12 / 12 12 / 12 0.00
command/stamp/list.ts 29 / 31 29 / 31 0.00
command/stamp/rename.ts 16 / 17 16 / 17 0.00
command/stamp/show.ts 13 / 14 13 / 14 0.00
command/stamp/stamp-command.ts 3 / 7 3 / 7 0.00
command/stamp/topup.ts 11 / 23 11 / 23 0.00
command/utility/cid.ts 8 / 13 8 / 13 0.00
command/utility/create-batch.ts 35 / 38 35 / 38 0.00
command/utility/index.ts 14 / 22 14 / 22 0.00
command/utility/lock.ts 7 / 11 7 / 11 0.00
command/utility/rchash.ts 27 / 27 27 / 27 0.00
command/utility/redeem.ts 43 / 51 43 / 51 0.00
command/utility/unlock.ts 7 / 12 7 / 12 0.00
command/wallet/index.ts 7 / 7 7 / 7 0.00
command/wallet/status.ts 11 / 11 11 / 11 0.00
command/wallet/withdraw-bzz.ts 19 / 21 19 / 21 0.00
command/wallet/withdraw-dai.ts 19 / 21 19 / 21 0.00
service/version_checker.ts 25 / 29 25 / 29 0.00
service/access/index.ts 29 / 31 29 / 31 0.00
service/access/types/history-event.ts 5 / 5 5 / 5 0.00
service/history/index.ts 19 / 21 19 / 21 0.00
service/identity/index.ts 32 / 36 32 / 36 0.00
service/identity/types/identity.ts 4 / 4 4 / 4 0.00
service/identity/types/index.ts 1 / 1 1 / 1 0.00
service/stamp/index.ts 30 / 32 30 / 32 0.00
utils/bzz-address.ts 24 / 30 24 / 30 0.00
utils/chainsync.ts 4 / 4 4 / 4 0.00
utils/contracts.ts 6 / 6 6 / 6 0.00
utils/error.ts 45 / 51 45 / 51 0.00
utils/hex.ts 10 / 14 10 / 14 0.00
utils/index.ts 65 / 83 65 / 83 0.00
utils/message.ts 3 / 12 3 / 12 0.00
utils/mime.ts 5 / 5 5 / 5 0.00
utils/option.ts 5 / 5 5 / 5 0.00
utils/qr.ts 5 / 5 5 / 5 0.00
utils/rpc.ts 43 / 50 43 / 50 0.00
utils/spinner.ts 15 / 15 15 / 15 0.00
utils/text.ts 25 / 27 25 / 27 0.00
utils/url.ts 6 / 6 6 / 6 0.00
utils/validate.ts 9 / 11 9 / 11 0.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants