Skip to content

Update all quickstarts from SDK repo#1444

Open
a-maurice wants to merge 3 commits into
masterfrom
am-update_quickstarts
Open

Update all quickstarts from SDK repo#1444
a-maurice wants to merge 3 commits into
masterfrom
am-update_quickstarts

Conversation

@a-maurice

Copy link
Copy Markdown
Contributor

Update all the product quickstarts from the changes in firebase-unity-sdk. A majority of the changes are updating the editor version, but there are some functionality changes, especially in Analytics and FirebaseAI. Along with that, remove the Dynamic Links one, as that is no longer supported.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates multiple Firebase Unity test apps to Unity 2021.3.43f1, removes the deprecated Dynamic Links test app, and introduces several features including on-device conversion measurement in Analytics, App Check and usage metadata logging in FirebaseAI, Firestore emulator and transaction support, and async storage operations. The code review identified several critical issues: a syntax error due to a missing closing brace in Firestore's object equality helper, unsafe initialization of App Check before verifying dependencies, potential null reference exceptions in FirebaseAI's metadata logging, a risk of unhandled aggregate exceptions in Messaging's token retrieval, and an encoding mismatch between file uploads and downloads in Storage.

Comment thread firestore/testapp/Assets/Firebase/Sample/Firestore/UIHandler.cs Outdated
Comment thread firebaseai/testapp/Assets/Firebase/Sample/FirebaseAI/UIHandler.cs
Comment thread messaging/testapp/Assets/Firebase/Sample/Messaging/UIHandler.cs
Comment thread firebaseai/testapp/Assets/Firebase/Sample/FirebaseAI/UIHandler.cs
Comment thread storage/testapp/Assets/Firebase/Sample/Storage/UIHandler.cs
@a-maurice a-maurice requested a review from AustinBenoit June 23, 2026 22:28
private DependencyStatus dependencyStatus = DependencyStatus.UnavailableOther;
protected FirebaseFunctions functions;


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

});
}


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

}



Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

// the required dependencies to use Firebase, and if not,
// add them if possible.
protected virtual void Start() {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

yield return new WaitUntil(() => task.IsCompleted);
}


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

}



Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants