Skip to content

feat(scopes): use TransactionSampler#2120

Open
Litarnus wants to merge 1 commit into
transaction-samplerfrom
use-transaction-sampler
Open

feat(scopes): use TransactionSampler#2120
Litarnus wants to merge 1 commit into
transaction-samplerfrom
use-transaction-sampler

Conversation

@Litarnus

@Litarnus Litarnus commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Use TransactionSampler instead of the transaction function. Also make it static as it doesn't require state

@Litarnus Litarnus force-pushed the transaction-sampler branch from 0ab8198 to 99d01dc Compare June 15, 2026 13:19
@Litarnus Litarnus force-pushed the use-transaction-sampler branch from d4ded95 to 5c69016 Compare June 15, 2026 13:20
@Litarnus Litarnus marked this pull request as ready for review June 22, 2026 14:38
Comment thread src/Tracing/TransactionSampler.php
Comment thread src/Tracing/TransactionSampler.php
@Litarnus Litarnus force-pushed the transaction-sampler branch from 99d01dc to 346a63d Compare June 22, 2026 22:12
@Litarnus Litarnus force-pushed the use-transaction-sampler branch from 5c69016 to 2e630c8 Compare June 22, 2026 22:12
Comment thread src/Tracing/TransactionSampler.php
@Litarnus Litarnus force-pushed the transaction-sampler branch from 346a63d to 0878a69 Compare June 22, 2026 22:46
@Litarnus Litarnus force-pushed the use-transaction-sampler branch from 2e630c8 to 012018d Compare June 22, 2026 22:46
Comment thread src/Tracing/TransactionSampler.php
@Litarnus Litarnus force-pushed the transaction-sampler branch from 0878a69 to 472a3ab Compare June 22, 2026 22:54
@Litarnus Litarnus force-pushed the use-transaction-sampler branch from 012018d to 3b8b293 Compare June 22, 2026 22:54

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3b8b293. Configure here.

Comment thread src/Tracing/TransactionSampler.php
@Litarnus Litarnus force-pushed the transaction-sampler branch from 472a3ab to 7de1710 Compare June 24, 2026 11:14
@Litarnus Litarnus force-pushed the use-transaction-sampler branch from 3b8b293 to c316d3e Compare June 24, 2026 11:14
Comment thread src/Tracing/TransactionSampler.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant