installer: refine git pull behavior text to prevent misconfiguration#682
installer: refine git pull behavior text to prevent misconfiguration#682jzbakh wants to merge 1 commit into
Conversation
|
Reopened: head repository restored after accidental deletion. |
|
Hmm. I'm not sure that that wording is any clearer. Maybe a better idea would be to add a page on gitforwindows.org and then to add a footer to this installer page that links to that documentation? That way, there is a lot more space to work with. |
|
Makes sense. I'll write a doc page for
|
I like this option a lot! |
This commit adds a footernote to the `GitPullBehaviorPage` directing users to the guide on the Git for Windows website regarding the default behavior of `git pull`. Signed-off-by: Jason Zbakh <jzbakh@gmail.com>
f0da980 to
2318f57
Compare
|
@dscho I'm currently working on the documentation page we discussed, and it got me thinking about the installer screen again. I completely agree with your previous feedback: my first version with the diagrams and the note on conflicts was too dense and unclear. However, I feel there are still a few issues with the current installer text:
Currently, the top of the screen displays two lines:
This is exactly what initially prompted me to propose an improvement. If we replace that second line with: "A pull always attempts a fast-forward first.", the context would become clearer, avoiding the need to explain fast-forwarding for each option. We could then align the option titles with the internal variables (
I just wanted to see if you agree with this approach. If so, I can use these exact headings and descriptions while writing the documentation page. What do you think? |
Description
The previous phrasing of the
git pullbehavior defaults could lead to unintended configurations of thepull.rebasevspull.ffparameters in the global.gitconfig. This PR refactors the text to introduce strict mechanical representations of the git state machine. The goal is to reduce ambiguity concerning commit graph resolution and align the UI text with current upstream defaults.Technical Scope
CreatePageandCreateRadioButtonfunctions for theGP_GitPullMerge,GP_GitPullRebase, andGP_GitPullFFOnlyoptions.TLabel(LblInfo) was added at the bottom of the page to clarify how Git handles file conflicts.ReplayChoice), or silent install vectors were altered. The internal component IDs remain untouched.Visual Regression Testing
Signed-off-by: Jason Zbakh jzbakh@gmail.com