fix: guard copyExportedFields against nil interface values in slices, maps, and pointers#127
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
fredbi
June 19, 2026 07:27
View session
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
=========================================
Coverage ? 91.66%
=========================================
Files ? 97
Lines ? 12623
Branches ? 0
=========================================
Hits ? 11571
Misses ? 828
Partials ? 224 ☔ View full report in Codecov by Harness. |
…s in slices, maps, and pointers When copyExportedFields recursively processes elements in slices, maps, or pointer targets that are nil interfaces, it returns nil. Calling reflect.ValueOf(nil) produces a zero reflect.Value, which panics when passed to Set. Add nil guards after each recursive call. Also removes a stale rapid fail file and regenerates docs. Signed-off-by: Frédéric BIDON <fredbi@yahoo.com> Co-Authored-by: copilot-swe-agent[bot] <198982749+copilot-swe-agent[bot]@users.noreply.github.com>
bfffa87 to
bbe0caf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copyExportedFieldspanics when encountering nil interface elements inside slices, maps, or pointer targets.reflect.ValueOf(nil)returns a zeroreflect.Value; calling.Set()with it panics. Discovered by therapid-based fuzz testTestNilSafetyExportedValues.Changes
internal/assertions/equal.go— Add nil guards after each recursivecopyExportedFieldscall in the slice/array, map, and pointer branches. Nil results skipSet, preserving the zero value (correct semantics: nil interface has no exported fields).TestNilSafetyExportedValues.go generate ./...(line number shifts from recent changes).